Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External link modal styling #6792

Closed
exezbcz opened this issue Aug 18, 2023 · 2 comments · Fixed by #6795
Closed

External link modal styling #6792

exezbcz opened this issue Aug 18, 2023 · 2 comments · Fixed by #6795
Assignees
@floyd-li
Labels
A-modal issues related to modals p3 non-core, affecting less than 40% visual change not affecting ux of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Aug 18, 2023

image

  • missing stroke and drop shadow

  • can we please also make the modal background the whole screen, covering the navbar as well
@exezbcz exezbcz added p3 non-core, affecting less than 40% visual change not affecting ux of app A-modal issues related to modals labels Aug 18, 2023
@floyd-li
Copy link
Member

👋

@kodabot
Copy link
Collaborator

kodabot commented Aug 18, 2023

ASSIGNED - @floyd-li 🔒 LOCKED -> Sunday, August 20th 2023, 03:12:11 UTC -> 36 hours

@floyd-li floyd-li mentioned this issue Aug 18, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floyd-li floyd-li

Labels
A-modal issues related to modals p3 non-core, affecting less than 40% visual change not affecting ux of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: redirect modal style floyd-li/nft-gallery
3 participants
@floyd-li @exezbcz @kodabot