Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer Redesign handover - (3) Transaction loading modal #6467

Closed
1 task
Jarsen136 opened this issue Jul 25, 2023 · 10 comments · Fixed by #6962
Closed
1 task

Transfer Redesign handover - (3) Transaction loading modal #6467

Jarsen136 opened this issue Jul 25, 2023 · 10 comments · Fixed by #6962
Assignees
@daiagi
Labels
$$ ~51-150usd A-transfer payment processing in transfer design-request p3 non-core, affecting less than 40%

Comments

@Jarsen136
Copy link
Contributor

related to #6460

Task:

  • desktop redesign of these part
image

figma: https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=890%3A14850&mode=dev
@yangwao yangwao added A-transfer payment processing in transfer p2 core functionality, or is affecting 60% of app $ ~<50usd labels Jul 25, 2023
@exezbcz
Copy link
Member

exezbcz commented Aug 1, 2023

@Jarsen136 This task will be in a more complex issue. For now, please skip this one.

@exezbcz exezbcz added p3 non-core, affecting less than 40% and removed p2 core functionality, or is affecting 60% of app labels Aug 1, 2023
@yangwao yangwao added good first issue as new commer, something you could start with $$ ~51-150usd and removed $ ~<50usd labels Aug 10, 2023
@exezbcz exezbcz added design-request and removed good first issue as new commer, something you could start with labels Aug 10, 2023
@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

This task will be in a more complex issue. For now, please skip this one.

w/o this there is missing copy transaction

@yangwao yangwao mentioned this issue Aug 21, 2023
Closed
@daiagi
Copy link
Contributor

daiagi commented Aug 21, 2023

so where do we stand?
is it ready for taking or something else needs to be done first?

@yangwao
Copy link
Member

yangwao commented Aug 21, 2023

is it ready for taking or something else needs to be done first?

I think it could be made
cc @exezbcz

@exezbcz
Copy link
Member

exezbcz commented Aug 21, 2023 •
edited
Loading

@daiagi I think let's make it. I don't want to block for too long since @yangwao mentioned it's currently unusable without it. Although it's not exactly how I designed it, I will add additional features such as a minimize, mobile compatibility, and an updated toast notification system in a follow-up.

@Jarsen136
Copy link
Contributor Author

so where do we stand? is it ready for taking or something else needs to be done first?

@daiagi Are you currently working on it?

@daiagi daiagi self-assigned this Aug 23, 2023
@kodabot
Copy link
Collaborator

kodabot commented Aug 23, 2023

ASSIGNED - @daiagi 🔒 LOCKED -> Saturday, August 26th 2023, 11:28:51 UTC -> 72 hours

@daiagi
Copy link
Contributor

daiagi commented Aug 23, 2023

Yep

@yangwao
Copy link
Member

yangwao commented Aug 25, 2023

Any updates?

@daiagi
Copy link
Contributor

daiagi commented Aug 25, 2023

working on it
estimate about 75% done

@daiagi daiagi mentioned this issue Aug 26, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daiagi daiagi

Labels
$$ ~51-150usd A-transfer payment processing in transfer design-request p3 non-core, affecting less than 40%
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

transfer loading Modal kodadot/nft-gallery
5 participants
@yangwao @daiagi @Jarsen136 @exezbcz @kodabot