Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double stroke visual issue #6223

Closed
exezbcz opened this issue Jun 14, 2023 · 7 comments · Fixed by #6263
Closed

Double stroke visual issue #6223

exezbcz opened this issue Jun 14, 2023 · 7 comments · Fixed by #6263
Labels
p3 non-core, affecting less than 40% visual change not affecting ux of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Jun 14, 2023 •
edited
Loading

it is visible, for example, here:

image

  • slider

card layout buttons
image
@exezbcz exezbcz added p3 non-core, affecting less than 40% visual change not affecting ux of app labels Jun 14, 2023
@prachi00 prachi00 self-assigned this Jun 14, 2023
@kodabot
Copy link
Collaborator

kodabot commented Jun 14, 2023

ASSIGNED - @prachi00 🔒 LOCKED -> Friday, June 16th 2023, 05:02:28 UTC -> 36 hours

@exezbcz
Copy link
Member Author

exezbcz commented Jun 14, 2023

@prachi00 I believe @prury will add some more images where the double stroke is as well. Could you please wait till we find all the major ones?

Thanks!

@prury
Copy link
Member

prury commented Jun 14, 2023 •
edited
Loading

RMRK2 only:
image
image

image

image

Massmint:
image

still checking...done.

@exezbcz
Copy link
Member Author

exezbcz commented Jun 14, 2023

Appreciate @prury. Thanks for your help.

I think its ready @prachi00

@prachi00
Copy link
Member

Screen Shot 2023-06-15 at 10 10 48 PM

@prury in rmrk2 it looks like this for me, no double stroke

@kodabot
Copy link
Collaborator

kodabot commented Jun 16, 2023

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@prury
Copy link
Member

prury commented Jun 16, 2023

Screen Shot 2023-06-15 at 10 10 48 PM

@prury in rmrk2 it looks like this for me, no double stroke

another PR seems to have fixed it

prachi00 added a commit that referenced this issue Jun 17, 2023
@prachi00
#6223 double stroke issues
5925da0
@prachi00 prachi00 mentioned this issue Jun 17, 2023
Merged
7 tasks
vikiival pushed a commit that referenced this issue Jul 11, 2023
@prachi00 @github-actions
#6223 double stroke issues (#6263)
675ccfd 
* #6223 double stroke issues

* Update components/collection/unlockable/UnlockableLoader.vue

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* common css

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p3 non-core, affecting less than 40% visual change not affecting ux of app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6223 double stroke issues kodadot/nft-gallery
4 participants
@prury @prachi00 @exezbcz @kodabot