Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebars open over each other #5672

Closed
exezbcz opened this issue Apr 14, 2023 · 8 comments · Fixed by #6407
Closed

Sidebars open over each other #5672

exezbcz opened this issue Apr 14, 2023 · 8 comments · Fixed by #6407
Labels
A-sidebar related to sidebars bug Something isn't working p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@exezbcz
Copy link
Member

exezbcz commented Apr 14, 2023

  • the sidebars are stacking on top of each other - notification sidebar and wallet sidebar
  • it should close the last one and open the new one
  • the overlay is also applied twice now - screen gets even darker
    image
    image
@exezbcz exezbcz added UX first Improvement for UX $ ~<50usd p3 non-core, affecting less than 40% labels Apr 14, 2023
@yangwao
Copy link
Member

yangwao commented Apr 15, 2023

sidebar enabled in pinia store soon

@exezbcz
Copy link
Member Author

exezbcz commented Apr 15, 2023

wallet sidebar double stacking as well

  • open sidebar, switch network, open sidebar again

image
image

@exezbcz
Copy link
Member Author

exezbcz commented Apr 30, 2023

any update on this? 👀

@exezbcz
Copy link
Member Author

exezbcz commented May 13, 2023

Trade Offer

@exezbcz exezbcz added bug Something isn't working A-sidebar related to sidebars labels May 13, 2023
@exezbcz
Copy link
Member Author

exezbcz commented Jun 14, 2023

lmao not sure whether I have the creativity to create better meme :D

It just would be nice to fix this xd

@kodadot/internal-dev anyone who would like to pick it up? 👀

@exezbcz
Copy link
Member Author

exezbcz commented Jun 18, 2023

Sad Pablo Escobar

@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app and removed $ ~<50usd p3 non-core, affecting less than 40% labels Jun 18, 2023
@roiLeo
Copy link
Contributor

roiLeo commented Jul 6, 2023

This one not so easy, I've wasted a lot of time trying to find a proper way to correct this problem.

either we try to correct it with what we currently have (but in a few months this code will no longer be used), or we can try to migrate to #6277 first, I vote 2nd option

edit: or we can migrate these "modal" to NeoSidebar component

edit2: nvm found a workaround (#6407)

@exezbcz
Copy link
Member Author

exezbcz commented Jul 7, 2023

or we can try to migrate to #6277 first, I vote 2nd option

Yup, I am for the long-term solutions.

edit2: nvm found a workaround (#6407)

nice! I will check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sidebar related to sidebars bug Something isn't working p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants