Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we using markdown-it library? If not, let's remove it #2036

Closed
yangwao opened this issue Jan 23, 2022 · 3 comments
Closed

Are we using markdown-it library? If not, let's remove it #2036

yangwao opened this issue Jan 23, 2022 · 3 comments
Labels
$ ~<50usd 🧹 - clean-up p2 core functionality, or is affecting 60% of app

Comments

@yangwao
Copy link
Member

yangwao commented Jan 23, 2022

I'm confused, by search result we are using markdown-it but it's not in package.json?

If it's not used, let's remove it.

Probably we are using vue-markdown-render

Ref

@yangwao yangwao added $ ~<50usd p2 core functionality, or is affecting 60% of app 🧹 - clean-up labels Jan 23, 2022
@roiLeo
Copy link
Contributor

roiLeo commented Jan 23, 2022

We're using it currently to render markdown from .json in langDir files cf.

const md = MarkdownIt({

ref in #1614 for i18n plugin config

@kkukelka
Copy link
Member

we still need it. re-checked in #2096

@roiLeo
Copy link
Contributor

roiLeo commented Jun 7, 2022

closing this for now since we need it, might be time to check @nuxt/content for #2692

@roiLeo roiLeo closed this as completed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd 🧹 - clean-up p2 core functionality, or is affecting 60% of app
Projects
None yet
Development

No branches or pull requests

3 participants