Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox version is broken #28

Closed
nikocraft opened this issue Jul 13, 2019 · 8 comments
Closed

Firefox version is broken #28

nikocraft opened this issue Jul 13, 2019 · 8 comments

Comments

@nikocraft
Copy link

Hi are you aware that this component barly functions in Firefox, and it's exibiting strange behaviour. I'm using it for my CMS: https://www.youtube.com/watch?v=O-fO41eOp6o

Is there a chance you could take a look at this and see what's going crazy in FF? You can test it right in your demo links since the issue is there right when you start using it in FF.

@elevatebart
Copy link
Contributor

Hey @nikocraft

What version of Firefox are you using and what are the specs of your computer?
You might want to try disabling plugins as well to speed it up.
I just tried it out in FF and it purrs.

My config:
Firefox 68.0.1 (64-bit) on windows 10 with a laptop of early 2015.

@nikocraft
Copy link
Author

My config is 68.0 on windows 10, same page works in Chrome without any strange behaviour. See this video I just made for you on FF 68.0

https://www.youtube.com/watch?v=-jzH5_hfV-g

I had to press enter two times on line 1 to be able to go to line 2
On line 2 I pressed tab once only and cursort jumped now to line 3
These are just two weird things I found out, I'm sure there are more.

I'm not using any plugins on FF, it's a clean install. None of the behaviour seen in the video above happens in Chrome.

All tested here: https://codesandbox.io/s/61yrlnlnmn

@elevatebart
Copy link
Contributor

I reproduce easily in codesandbox indeed.
I believe it either has to do with starting from an empty editor or to do with CodeSandbox since it is not happening here at all.

I will have a quick look.

@koca
Copy link
Owner

koca commented Jul 30, 2019

@elevatebart agree. In codesandbox it behaves strange but as you mentioned seems ok.

@nikocraft
Copy link
Author

nikocraft commented Jul 30, 2019

I had exact same behaviour in my CMS. I had to turn off the plugin completly in the CMS. Anyways why would sandbox work just fine in Chrome but not in FF, something is strange with FF version. I've had people complain to me that it was giving them problems in FF with my CMS, that's why I started to investigate it and since we could not fix it I turned it off in FF, but also reported it here for you in hopes you'll be able to figure it out.

@elevatebart
Copy link
Contributor

Have your users complained about non-empty editors?
I am simply trying to start somewhere for the fix.

Firefox is my main browser, I want to make sure it works for me ;-)

@nikocraft
Copy link
Author

nikocraft commented Jul 30, 2019

What is non-empty editor? In my CMs initially there is no code in prism-editor, users have to put it there first if they want to customize stuff.
I believe I reported a bug for you about this before and you guys fixed it, see this:
#17

So do you guys think it's a problem if editor is initiated empty and FF starts to missbehave because of this?

@koca koca mentioned this issue Jun 21, 2020
@koca
Copy link
Owner

koca commented Aug 8, 2020

Released new version v1 🎉

@koca koca closed this as completed Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants