-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kobo iOS] [Kobo Android] Publisher’s default + text-align #28
Comments
Can you send a sample ePub or do you know of any files formatted in this way that are already in production? I'd be interested in testing in both environments. |
@JayPanoz just checking again to see if you have a sample? It would be difficult to scan our system specifically for a file with that CSS. |
Ok so there’s actually no need for a sample, the solution is actually pretty simple. In my EPUB file I had:
And there was no The assumption being: “well, I'm using Since contents are appended in a div, When the user setting is set (2), That's probably an edge case but as far as I can remember, it's not the first time I encounter EPUB files in which such a prop is declared for a global element so I guess it's worth reporting it. Maybe declaring a fallback |
@JayPanoz thanks for the follow up and the snippet. I'm not going to log this as a bug fix because 1) it is an edge case (we don't see this happen in any of the content we review) and 2) technically our app is doing what the content is telling it. |
So, when text-align is not declared in the CSS and you pick “Publisher’s default” setting in the menu, the whole text is centered (by default).
For the record, if you set
text-align: left
for h1 for instance, then the whole text is left-aligned when using this setting.Applies to Kobo iOS and Kobo Android.
The text was updated successfully, but these errors were encountered: