Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved discussion on leakage #1

Open
bgreenwell opened this issue Jan 29, 2023 · 3 comments
Open

Improved discussion on leakage #1

bgreenwell opened this issue Jan 29, 2023 · 3 comments

Comments

@bgreenwell
Copy link
Member

Great resource: https://reproducible.cs.princeton.edu/

Really ties into preprocessing before data splitting and dealing with class imbalance!

@bradleyboehmke
Copy link
Member

In the ed. 1 we talked about leakage in the feature engineering section: https://bradleyboehmke.github.io/HOML/engineering.html#data-leakage

Are you thinking keep it in that same location or move/expand to elsewhere?

@bgreenwell
Copy link
Member Author

Definitely expanding, and maybe reference the idea of “model info sheets”: https://reproducible.cs.princeton.edu/. I also have a few simulations illustrating the impact of leakage in the preprocessing stage (like feature selection followed by cross validation and up sampling).

@bgreenwell
Copy link
Member Author

Illegitimate features is another one we don’t really discuss, but seems to be a common issue.

@bgreenwell bgreenwell changed the title New discussion on leakage Improved discussion on leakage Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants