PR 110: new default #120
Merged
PR 110: new default #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code, the tests, the docs.
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 80 80
Branches 29 29
=========================================
Hits 80 80
Continue to review full report at Codecov.
|
|
I merged the wrong PR |
niftylettuce
approved these changes
Jul 6, 2020
|
v5.0.0 published to npm and GitHub https://github.com/koajs/compress/releases/tag/v5.0.0 |
dobesv
reviewed
Jul 6, 2020
| app.use(sendBuffer) | ||
| request(server) | ||
| .get('/') | ||
| .set('Accept-Encoding', '') |
There was a problem hiding this comment.
unset() didn't work, but setting the empty value did the trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the code, the tests, and the docs. Incidentally, the lock file was out of sync with the package file, so it is trivially updated too.
It is built on PR #110 according to the comment #110 (comment) as mentioned in #112