Enable setting the working dir for the go tool #365
Conversation
|
Can you explain the |
And to resolve local "import paths" correctly, the function needs to know the current directory, from the new
Not without changing the method signatures AFAICT. We could call a non-exported |
pkg/commands/options/build.go
Outdated
|
|
||
| // Dir allows for setting the working directory for invocations of the `go` tool. | ||
| // Empty string means the current working directory. | ||
| Dir string |
There was a problem hiding this comment.
Can we rename this to WorkingDir or WorkingDirectory? I think that would help with the name collision for #365
There was a problem hiding this comment.
Done. Also squashed the commits.
This change adds a `WorkingDirectory` field to `options.BuildOptions`, but doesn't expose this as a CLI flag. The default zero value means the current working directory. The value is used as the directory for executing `go` tool commands. When embedding ko in other tools, it is sometimes necessary to set the working directory for executing the `go` tool, instead of assuming the current process working directory. An example of where this is required from Skaffold: https://github.com/GoogleContainerTools/skaffold/tree/master/examples/microservices In this example, the working directory doesn't contain either `go.mod` or any Go files. The `skaffold.yaml` configuration file specifies a `context` field for each image, which is the directory where the `go` tool can find package information.
This change adds a
WorkingDirectoryfield tooptions.BuildOptions, but doesn'texpose this as a CLI flag. The default zero value means the current
working directory. The value is used as the working directory for
executing
gotool commands.When embedding ko in other tools, it is sometimes necessary to set the
working directory for executing the
gotool, instead of assuming thecurrent process working directory.
An example of where this is required from Skaffold:
https://github.com/GoogleContainerTools/skaffold/tree/master/examples/microservices
In this example, the working directory doesn't contain either
go.modor any Go files. The
skaffold.yamlconfiguration file specifiesa
contextfield for each image, which is the directory where thegotool can find package information.
I considered updating the
buildContextinterface to wrapgo/build.Context.That'd avoid duplicating the
dirfield ingobuildandbuildContext.Instead of add that to this pull request, I made that change in another branch,
mainly to explore what that could look like:
https://github.com/halvards/ko/blob/base-dir-buildcontext/pkg/build/context.go#L17
PLMKWYT (this could be a starting point for #305)