-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document support/expectations for consuming ko as a library #554
Comments
From the peanut gallery, I would personally love it if you made a really simple example of using For my selfish use case, I wish to build my application and use the git SHA1 both as the image tag as well as inject the git SHA1 into the go binary at build time. Currently, I need to manipulate the |
@StevenACoffman That's a useful request, far from a peanut gallery. I think we could document something like this gist that's a pretty minimal |
Thanks! That's so exactly what I wished for! Also perhaps noting that dvob/sko is this without the ldflags. |
@imjasonh how about adding the contents of that gist to the repo? Say under |
This issue is stale because it has been open for 90 days with no |
From: https://www.reddit.com/r/golang/comments/rhyn52/should_i_import_code_from_open_source_projects/
Since the hard work by @halvards in #348,
ko
's build behavior is more easily consumable by other code that wants it. That's undeniably great. 👏We could do a better job of documenting how to do that, either in README or in a separate page that's linked from README. Something simple like documenting how the
build
package works, and feeds into thepublish
package, with links to godoc to explore the full set of options.We should also document expectations about stability of those packages. I'd like to make it clear that
ko
-the-CLI is the main way we expect people to consume the behavior, but that packages are available on a best-effort basis. There's CLI behavior we don't make available as a package (e.g.,internal/sbom
), and there might be changes to the packages to improve the CLI experience (e.g., #551) that may break consumers of the Go packages -- we'll try to limit the severity, but I don't think we should commit to full compatibility indefinitely. Upon upgrading a dependency ongithub.aaakk.us.kg/google/ko
, consumers may have build breakages or behavior changes.Thoughts? @halvards @jonjohnsonjr
The text was updated successfully, but these errors were encountered: