Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko with monorepo #51

Closed
xmlking opened this issue Jul 3, 2019 · 4 comments
Closed

ko with monorepo #51

xmlking opened this issue Jul 3, 2019 · 4 comments

Comments

@xmlking
Copy link
Contributor

xmlking commented Jul 3, 2019

I have a monorepo (using go modules) https://github.com/xmlking/micro-starter-kit
Where multiple deployable services sharing common code.
Will ko support monorepos? What is the best practice to layout and use ko with monorepos

@jonjohnsonjr
Copy link
Collaborator

See my comment here #50 (comment)

I believe we would just look for the root go.mod file and use that to locate packages. With a monorepo, do you have multiple go.mod files?

@xmlking
Copy link
Contributor Author

xmlking commented Jul 9, 2019

i only have one go.mod at monorepo root. but multiple containerise-able services in /srv sharing common code in /shared

Tested and it is working fine with image: github.com/xmlking/micro-starter-kit/srv/account in deployment.yaml

I am using this workaround till go-modules supported

@jonjohnsonjr
Copy link
Collaborator

We landed go module support a while ago. Is this still an issue for you @xmlking ?

@xmlking
Copy link
Contributor Author

xmlking commented Oct 23, 2019

no , thanks

@xmlking xmlking closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants