Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ko login #155

Closed
mattmoor opened this issue Apr 30, 2020 · 9 comments · Fixed by #243 or #277
Closed

Support ko login #155

mattmoor opened this issue Apr 30, 2020 · 9 comments · Fixed by #243 or #277

Comments

@mattmoor
Copy link
Collaborator

ko consumes the Docker keyring, but generally it is a pain in the butt to configure this without Docker installed.

I propose we add ko login mimicing the behavior of docker login so that folks can reasonable authenticate without having docker installed.

This likely needs work in github.com/google/go-containerregistry, and come to think of it a crane login command sounds useful too!

@mattmoor
Copy link
Collaborator Author

@jonjohnsonjr since you added crane auth login 👀

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@jonjohnsonjr
Copy link
Collaborator

Fixed by #243

@alexellis
Copy link

Hi guys, the README file says ko auth login exists, but go get with the latest stable release doesn't seem to support it.

Is the resolution to pull the master version or is that a bug?

Alex

@alexellis
Copy link

There may also be a minor bug in the usage text mentioning crane?

Usage:
  ko auth login [OPTIONS] [SERVER] [flags]

Examples:
  # Log in to reg.example.com
  crane auth login reg.example.com -u AzureDiamond -p hunter2

Flags:
  -h, --help              help for login
  -p, --password string   Password
      --password-stdin    Take the password from stdin
  -u, --username string   Username

@jonjohnsonjr
Copy link
Collaborator

Yeah... #243 (comment)

I can refactor some things to make this less gross (we just want ko login not ko auth login, IMO.

@jonjohnsonjr jonjohnsonjr reopened this Nov 30, 2020
@alexellis
Copy link

I would like to see some output, if you're open to it after running the login command like Wrote to... ~/.docker/config.json or some other output if the file wasn't updated (because it already existed)

@jonjohnsonjr
Copy link
Collaborator

I would like to see some output, if you're open to it after running the login command like Wrote to... ~/.docker/config.json or some other output if the file wasn't updated (because it already existed)

Seems reasonable to me!

@jonjohnsonjr
Copy link
Collaborator

jonjohnsonjr commented Dec 22, 2020

Once we update dependencies, we should be able to merge a fix for this, then cut a release, which will make it available everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants