Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko ignores packages that contain their own go.mod #148

Closed
antoineco opened this issue Apr 8, 2020 · 5 comments
Closed

ko ignores packages that contain their own go.mod #148

antoineco opened this issue Apr 8, 2020 · 5 comments

Comments

@antoineco
Copy link
Contributor

antoineco commented Apr 8, 2020

Given the following project structure:

.
├── cmd
│  ├── awscodecommitsource
│  │   ├── go.mod
│  │   ├── go.sum
│  │   └── main.go
│  └── controller
│      └── main.go
├── go.mod
└── go.sum

and the following manifest (simplified):

apiVersion: apps/v1
kind: Deployment
metadata:
  name: aws-sources-controller
    spec:
      containers:
      - name: controller
        image: ko://github.com/triggermesh/aws-event-sources/cmd/controller
        env:
        - name: AWSCODECOMMITSOURCE_IMAGE
          value: ko://github.com/triggermesh/aws-event-sources/cmd/awscodecommitsource

ko builds the image for cmd/controller but ignores cmd/awscodecommitsource, and keeps the literal value.

After removing go.mod and go.sum from cmd/awscodecommitsource, ko builds both images and replaces the value accordingly.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@antoineco
Copy link
Contributor Author

/remove-lifecycle stale

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@jonjohnsonjr
Copy link
Collaborator

This might be addressed by #305

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants