Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing to ECR without logging in first doesn't work #1245

Closed
espadolini opened this issue Feb 23, 2024 · 3 comments · Fixed by #1267
Closed

Pushing to ECR without logging in first doesn't work #1245

espadolini opened this issue Feb 23, 2024 · 3 comments · Fixed by #1267

Comments

@espadolini
Copy link

ko 0.15.2 fails to push images to ECR from GitHub actions without first running aws-actions/amazon-ecr-login.

The "Push to registries/Push to ECR" action in this very repo stopped passing since c23121a (https://github.com/ko-build/ko/actions/runs/7109904995/job/19355555999#step:6:18), so that's the likely culprit.

@cpanato
Copy link
Member

cpanato commented Feb 23, 2024

That failure is because of some IAM changes in the account that removed the access to push, most likely. I cannot confirm 100% because I don't have access. But the test has been failing for a long time now

@espadolini
Copy link
Author

I've had it fail just like that on a private repo, and work with no changes to the aws side after reverting from ko 0.15.2 to ko 0.15.1 or by adding an aws-actions/amazon-ecr-login step before the ko one.

@cpanato
Copy link
Member

cpanato commented Feb 23, 2024

Hmm I see I will take a look

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants