Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize mermaid #524

Merged
merged 33 commits into from
Apr 24, 2017
Merged

Modernize mermaid #524

merged 33 commits into from
Apr 24, 2017

Conversation

tylerlong
Copy link
Collaborator

@tylerlong tylerlong commented Apr 21, 2017

Replace karma + PhantomJS with karma + Chrome headless

https://groups.google.com/forum/#!topic/phantomjs/9aI5d-LDuNE

Chrome is faster and more stable than PhantomJS. And it doesn't eat memory like crazy.

I don't see any future in developing PhantomJS. Developing PhantomJS 2 and 2.5 as a single developer is a bloody hell.

We will get rid of PhantomJS altogether in the future.

Get rid of browserify

Now there is no browserify. I replaced karma-browserify with karma-webpack.

Remove some useless code and libraries

gulp-uglify was removed because webpack has embedded uglify support.

jshint was remove because now we are using JavaScript Standard Style based on ESLint

Removed some gulp tasks because we no longer need them.

Add some documentation for contributors to readme

https://github.com/tylingsoft/mermaid#for-contributors

Use webpack to compile less into css

gulp-less was removed.

Update less code

Format and beautify less code.

Make all 5 kinds of diagrams look good in all 4 themes

Update sequence diagram, git graph and class diagram

Fixed some minor issues

Fix Travis CI

@tylerlong tylerlong changed the title Modenize mermaid Modernize mermaid Apr 21, 2017
@tylerlong tylerlong requested a review from knsv April 22, 2017 15:42
@tylerlong tylerlong self-assigned this Apr 22, 2017
@tylerlong
Copy link
Collaborator Author

tylerlong commented Apr 24, 2017

Travis CI build has been fixed.

Merging it. I will fix codeclimate in future PRs.

@tylerlong tylerlong merged commit 1a3d37d into mermaid-js:master Apr 24, 2017
mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
…yarn/develop/prettier-2.5.1

chore(deps-dev): bump prettier from 2.5.0 to 2.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants