-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix phantomjs2 compatibility #304
Comments
Thanks, will take a look. |
+1 |
I think that this become a critical issue. npm complains about installing an ancient version of phantomjs and even gives an warning regarding package name change:
If you happen to have a newer version installed the problem becomes even bigger. |
Here is something that may worked, but that is clearly not the desired UX
Not to say that it did take ages to build, because obviously we were not able to benefit from the prebuild versions. It still takes 100% of 2 cores of a top i7 (ssd), and after 1.5 hours it did not finish yet! |
We do not use PhantomJS any more. Ref: https://github.com/mermaidjs/mermaid.cli |
…yarn/develop/mocha-9.1.0 chore(deps-dev): bump mocha from 9.0.3 to 9.1.0
PhantomJS2 has no
phantom.args
anymore,System.args
should be used.http://phantomjs.org/api/phantom/property/args.html
The text was updated successfully, but these errors were encountered: