Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service deployment in namespace with resource quota fails due to missing request and limit on queue-proxy #4134

Closed
raushan2016 opened this issue May 20, 2019 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@raushan2016
Copy link
Contributor

In what area(s)?

/area API
/area serving

What version of Knative?

0.5.x
0.6.x

Expected Behavior

User should be able to create knative service in namepsace's with resource quota

Actual Behavior

Knative service creation fails, as the queue-proxy doesn't have default resource request and limit set. Currently it only has request.cpu set to 25m. The current work around is create a LimitRange in the namespace. Similar issue was for istio 0.5 for the sidecar proxy , but with latest version it now has default resource request and limits for the side-car. It would be nice to have it for queue-proxy.

Steps to Reproduce the Problem

  • Create a namespace
  • Add resource quota to the namespace with request and limit
  • Create a knative service.
  • The deployment fails with missing request and limit
    message: 'pods "helloworld-go-k9lw9-deployment-6478957b64-hp4zh" is forbidden: failed quota: resource-quota: must specify limits.cpu,limits.memory,requests.cpu,requests.memory'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant