Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Suppress the object has been modified output by default #15746

Open
kahirokunn opened this issue Feb 1, 2025 · 2 comments
Open
Labels
area/monitoring kind/feature Well-understood/specified features, ready for coding.

Comments

@kahirokunn
Copy link
Member

/area monitoring

Describe the feature

Overview

In Knative Serving, the "the object has been modified" logs and events that occur during object updates often only result in retries within the processing logic, creating significant noise due to frequent output. Since these are typically unnecessary during normal operations, could we modify them to not appear at standard log levels and only be displayed when needed in Debug mode (or Verbose log level)?

Why is this needed

  • In Knative Serving, object update conflicts are often resolved through retries without additional processing or errors occurring.
  • Unnecessary logs and events may obscure information that actually needs attention.
  • Currently, operators spend extra time reviewing unnecessary logs, which could also impact monitoring/alert settings.

Proposal

  • Suppress or hide by default (at a lower log level) the "the object has been modified" logs and events, only displaying them when log levels are explicitly increased.
  • Output detailed information only when necessary (for example, when retries fail after a certain number of attempts).

Expected Benefits

  • Reduced noisy log output, leading to lower operational overhead.
  • Easier identification of truly necessary logs and events without missing important information.
  • Ability to explicitly enable Debug/Verbose mode only when detailed logs are needed during error scenarios.

We would greatly appreciate your consideration of adding this functionality. Thank you for your consideration.

@kahirokunn kahirokunn added the kind/feature Well-understood/specified features, ready for coding. label Feb 1, 2025
@kahirokunn kahirokunn changed the title Feature Request: Suppress "the object has been modified" output by default and only retry as needed Feature Request: Suppress the object has been modified output by default and only retry as needed Feb 1, 2025
@kahirokunn kahirokunn changed the title Feature Request: Suppress the object has been modified output by default and only retry as needed Feature Request: Suppress the object has been modified output by default Feb 1, 2025
@dprotaso
Copy link
Member

dprotaso commented Feb 3, 2025

which controller/reconciler do you see this happening with the most?

@kahirokunn
Copy link
Member Author

I think there were a lot of outputs from multiple controllers, but I will check again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Development

No branches or pull requests

2 participants