Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move image to map #8362

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Move image to map #8362

merged 1 commit into from
Dec 3, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Dec 2, 2024

Proposed Changes

  • move image look up to map. will eventually be a config map

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@matzew
Copy link
Member Author

matzew commented Dec 2, 2024

/assign @dsimansk

@knative-prow knative-prow bot requested a review from Cali0707 December 2, 2024 14:19
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 2, 2024
@knative-prow knative-prow bot requested a review from Leo6Leo December 2, 2024 14:19
dsimansk
dsimansk reviewed Dec 2, 2024
View reviewed changes
pkg/reconciler/integration/source/resources/containersource.go
Comment on lines +125 to +135
switch {
case source.Spec.Timer != nil:
return sourceImageMap["timer"]
case source.Spec.Aws != nil && source.Spec.Aws.S3 != nil:
return sourceImageMap["aws-s3"]
case source.Spec.Aws != nil && source.Spec.Aws.SQS != nil:
return sourceImageMap["aws-sqs"]
case source.Spec.Aws != nil && source.Spec.Aws.DDBStreams != nil:
return sourceImageMap["aws-ddb-streams"]
default:
return ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the nested if-s a bit more, but it's still readable. :)

dsimansk
dsimansk approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 64.27%. Comparing base (408db83) to head (d9e8c9b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/integration/source/resources/containersource.go 27.27% 8 Missing ⚠️
...iler/integration/sink/resources/container_image.go 33.33% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8362      +/-   ##
==========================================
+ Coverage   64.26%   64.27%   +0.01%     
==========================================
  Files         389      389              
  Lines       23281    23276       -5     
==========================================
  Hits        14961    14961              
+ Misses       7526     7521       -5     
  Partials      794      794

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor

dsimansk commented Dec 2, 2024

/retest

@matzew
Move image to map
d9e8c9b 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew force-pushed the move_image_to_map branch from ab4773f to d9e8c9b Compare December 3, 2024 05:47
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@dsimansk
Copy link
Contributor

dsimansk commented Dec 3, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@knative-prow knative-prow bot merged commit 795e4a3 into knative:main Dec 3, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk dsimansk approved these changes

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzew @dsimansk