-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IntegrationSink CRD #8304
Add IntegrationSink CRD #8304
Conversation
be6d2a3
to
44151ad
Compare
44151ad
to
d378de7
Compare
d378de7
to
1283b65
Compare
ba47495
to
376a3e8
Compare
…er.go Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
376a3e8
to
b6fd865
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8304 +/- ##
==========================================
- Coverage 64.53% 64.23% -0.31%
==========================================
Files 380 390 +10
Lines 22772 23248 +476
==========================================
+ Hits 14697 14934 +237
- Misses 7300 7520 +220
- Partials 775 794 +19 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
00b2d0b
to
0a3f64e
Compare
Clean ups Adding tests for reconciler Signed-off-by: Matthias Wessendorf <[email protected]>
0a3f64e
to
9d7e051
Compare
apiVersion: cert-manager.io/v1 | ||
kind: Certificate | ||
metadata: | ||
name: integration-sink-server-tls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are actually not using this.
In a follow up PR, we will generate these Certificate
manifest for each IntegrationSource
instance (their Service
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
namespace: {{ .namespace }} | ||
{{ if .annotations }} | ||
{{ range $key, $value := .annotations }} | ||
{{ $key }}: {{ $value }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this helps when having annotations that are "boolean" but need to be represented as strings
{{ $key }}: {{ $value }} | |
{{ $key }}: "{{ $value }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah ... I fixed similar before, last week.
Will update it. eventually
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to #8185
Proposed Changes
IntegrationSink
CRD and tests. As alwasys, there is lot of boilerplate code when on-bording new componentPre-review Checklist
Release Note
Docs