Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

min-scale and max-scale updates #4956

Closed
abrennan89 opened this issue May 9, 2022 · 2 comments
Closed

min-scale and max-scale updates #4956

abrennan89 opened this issue May 9, 2022 · 2 comments
Labels
kind/cli status/blocked triage/needs-eng-input Engineering input is requested

Comments

@abrennan89
Copy link
Contributor

Expected Behavior

As per knative/client#958 --max-scale and --min-scale were updated to --scale-max and --scale-min

Actual Behavior

Docs haven't been updated

Steps to Reproduce the Problem

  1. https://knative.dev/docs/serving/autoscaling/container-freezer/#configure-min-scale
  2. https://knative.dev/docs/serving/autoscaling/scale-bounds/
  3. Anywhere else these commands need to update?
@abrennan89 abrennan89 added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/high kind/cli kind/documentation labels May 9, 2022
@cardil cardil mentioned this issue May 11, 2022
Closed
@abrennan89 abrennan89 removed kind/bug Categorizes issue or PR as related to a bug. priority/high kind/documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 22, 2022
@nader-ziada
Copy link
Member

The related PR in serving is still in progress
knative/serving#12972

@abrennan89 abrennan89 added triage/needs-eng-input Engineering input is requested status/blocked labels Aug 19, 2022
@abrennan89
Copy link
Contributor Author

Closing this until eng has their UX figured out. We can reopen a new issue for this if the update is still required later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cli status/blocked triage/needs-eng-input Engineering input is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nader-ziada @abrennan89