From c53ff9c610a4b97e292baa836ea89b416f33a73b Mon Sep 17 00:00:00 2001 From: David Simansky Date: Thu, 10 Sep 2020 18:26:28 +0200 Subject: [PATCH 1/3] fix: Fix service export example doc --- docs/cmd/kn_service_export.md | 4 ++-- pkg/kn/commands/service/export.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/cmd/kn_service_export.md b/docs/cmd/kn_service_export.md index 5a7f1af04d..034d76a70a 100644 --- a/docs/cmd/kn_service_export.md +++ b/docs/cmd/kn_service_export.md @@ -19,9 +19,9 @@ kn service export NAME # Export a service in JSON format kn service export foo -n bar -o json # Export a service with revisions - kn service export foo --with-revisions --mode=resources -n bar -o json + kn service export foo --with-revisions --mode=export -n bar -o json # Export services in kubectl friendly format, as a list kind, one service item for each revision - kn service export foo --with-revisions --mode=kubernetes -n bar -o json + kn service export foo --with-revisions --mode=replay -n bar -o json ``` ### Options diff --git a/pkg/kn/commands/service/export.go b/pkg/kn/commands/service/export.go index edb733b631..57af5cd263 100644 --- a/pkg/kn/commands/service/export.go +++ b/pkg/kn/commands/service/export.go @@ -60,9 +60,9 @@ func NewServiceExportCommand(p *commands.KnParams) *cobra.Command { # Export a service in JSON format kn service export foo -n bar -o json # Export a service with revisions - kn service export foo --with-revisions --mode=resources -n bar -o json + kn service export foo --with-revisions --mode=export -n bar -o json # Export services in kubectl friendly format, as a list kind, one service item for each revision - kn service export foo --with-revisions --mode=kubernetes -n bar -o json`, + kn service export foo --with-revisions --mode=replay -n bar -o json`, RunE: func(cmd *cobra.Command, args []string) error { if len(args) != 1 { return errors.New("'kn service export' requires name of the service as single argument") From 1bca2d296e0348da80de400023231eb2d2f9cb56 Mon Sep 17 00:00:00 2001 From: David Simansky Date: Thu, 10 Sep 2020 18:33:34 +0200 Subject: [PATCH 2/3] chore: Update changelog --- CHANGELOG.adoc | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc index 0a0f537041..c78e55ff77 100644 --- a/CHANGELOG.adoc +++ b/CHANGELOG.adoc @@ -12,6 +12,18 @@ | https://github.com/knative/client/pull/[#] //// +## Unreleased + +[cols="1,10,3", options="header", width="100%"] +|=== +| | Description | PR + +| 🐛 +| Fix service export example documentation +| https://github.com/knative/client/pull/1006[#1006] + +|=== + ## v0.17.0 (2020-08-26) [cols="1,10,3", options="header", width="100%"] From 4aaab55d8e7456dcae6809986a9d808f6bf2d87a Mon Sep 17 00:00:00 2001 From: David Simansky Date: Fri, 11 Sep 2020 12:34:51 +0200 Subject: [PATCH 3/3] fix: Add newline divider --- docs/cmd/kn_service_export.md | 3 +++ pkg/kn/commands/service/export.go | 3 +++ 2 files changed, 6 insertions(+) diff --git a/docs/cmd/kn_service_export.md b/docs/cmd/kn_service_export.md index 034d76a70a..de0ab5dcd8 100644 --- a/docs/cmd/kn_service_export.md +++ b/docs/cmd/kn_service_export.md @@ -16,10 +16,13 @@ kn service export NAME # Export a service in YAML format kn service export foo -n bar -o yaml + # Export a service in JSON format kn service export foo -n bar -o json + # Export a service with revisions kn service export foo --with-revisions --mode=export -n bar -o json + # Export services in kubectl friendly format, as a list kind, one service item for each revision kn service export foo --with-revisions --mode=replay -n bar -o json ``` diff --git a/pkg/kn/commands/service/export.go b/pkg/kn/commands/service/export.go index 57af5cd263..e05bcc7c2a 100644 --- a/pkg/kn/commands/service/export.go +++ b/pkg/kn/commands/service/export.go @@ -57,10 +57,13 @@ func NewServiceExportCommand(p *commands.KnParams) *cobra.Command { Example: ` # Export a service in YAML format kn service export foo -n bar -o yaml + # Export a service in JSON format kn service export foo -n bar -o json + # Export a service with revisions kn service export foo --with-revisions --mode=export -n bar -o json + # Export services in kubectl friendly format, as a list kind, one service item for each revision kn service export foo --with-revisions --mode=replay -n bar -o json`, RunE: func(cmd *cobra.Command, args []string) error {