update: Change default to server-side generated revision names (extended)

[rhuss]

Fixes #1144.

This is an extension of #1236 with better handling for service updates. If tests are passing then this PR should be merged instead of #1236

[rhuss]

@maximilien could I get this stamped please ? This is the PR that we talked about at the WG call, but a version that should be more robust (and irons out also my corner case). It checks now the generation's first before going into a wait loop. This should be much more robust as we did before anyway.

I would need this PR to be merged to continue with the 0.21 release (i will release the plugins then tomorrow, but would like to kick of the auto-release for kn already)

[rhuss]

@navidshaikh could you please approve + lgtm this PR ? When merged, I wold then kickoff the kn release.

[navidshaikh]

/lgtm
/approve

The changelog fix can be done in a follow up.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[rhuss]

Ah, good point. Fixed (and need another stamp now ;-)

[rhuss]

@navidshaikh Also stupid clabot needs some love again :)

thanks !

[navidshaikh]

@googlebot I fixed it.

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[navidshaikh]

@googlebot I fixed it.

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[navidshaikh]

/lgtm

[rhuss]

@googlebot I fixed it.

Maybe @googlebot I consent works better ?

If not, I'm going squash everything and push again

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[navidshaikh]

@googlebot I consent.

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[navidshaikh]

@rhuss : lets squash and push again

[rhuss]

@navidshaikh done. Hopefully we are at the last stamp ;-)

[navidshaikh]

/lgtm

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/configuration_edit_flags.go	85.2%	85.0%	-0.2
pkg/kn/commands/service/create.go	85.0%	84.5%	-0.5
pkg/kn/commands/service/update.go	91.1%	86.7%	-4.4
pkg/serving/v1/client.go	69.1%	69.3%	0.1
pkg/wait/wait_for_ready.go	76.9%	75.8%	-1.1