Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration should not use env var but config-kourier #877

Open
nak3 opened this issue Jul 15, 2022 · 8 comments
Open

Configuration should not use env var but config-kourier #877

nak3 opened this issue Jul 15, 2022 · 8 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@nak3
Copy link
Contributor

nak3 commented Jul 15, 2022

Currently some configurations especially external authorization use env variables as https://github.com/knative-sandbox/net-kourier#external-authorization-configuration instead of config-kourier configmap.

I think that there is no big reason for using env variable but we just used it because we haven't introduced config-kourier at that time.

Now, since new configurations are added in config-kourier, the env variables should be migrated into the configmap.

@nak3 nak3 added this to the Icebox milestone Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2022
@knative-prow-robot
Copy link

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 3, 2022
@dprotaso
Copy link
Contributor

dprotaso commented Dec 6, 2022

/lifecycle frozen

@knative-prow knative-prow bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Dec 6, 2022
@ReToCode
Copy link
Member

/good-first-issue

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 10, 2023
@ReToCode
Copy link
Member

The same would probably apply for CERTS_SECRET_NAMESPACE and CERTS_SECRET_NAME used in caches.go

@harshil1973
Copy link

I would like to contribute in this but I am an absolute beginner if anyone can help me by providing steps it would be nice

@nak3
Copy link
Contributor Author

nak3 commented May 12, 2023

Hmm... I think it is not a "good-first-issue" issue actually. It needs many steps for the change and one big concern is that some configurations might need to be loaded before ConfigMap informer's reconcile loop.
How do you think @ReToCode

@ReToCode
Copy link
Member

Yeah, I think it could be more complicated than initially though. I haven't checked if any of the configs actually is affected by what you described. But it is probably better to start with a simpler issue @harshil1973.

/remove-good-first-issue

@knative-prow knative-prow bot removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants