Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-deps bot does not send PR for only module diff #82

Open
nak3 opened this issue May 7, 2021 · 0 comments
Open

update-deps bot does not send PR for only module diff #82

nak3 opened this issue May 7, 2021 · 0 comments

Comments

@nak3
Copy link
Contributor

nak3 commented May 7, 2021

The script excludes diff in go.mod, go.sum and modules.txt:

https://github.com/knative-sandbox/knobots/blob/05c5158e8da094a33d708fd7c7d504faed62ca3b/actions/update-deps/entrypoint.sh#L59-L70

so update-deps bot does not create the PR even when deps have diff - e.g. https://github.com/knative-sandbox/knobots/runs/2523678545?check_suite_focus=true did not create PR (please check in Apply work)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   go.mod
	modified:   go.sum
	modified:   vendor/modules.txt

This is no problem in general as it is just a module name change. But it causes an error in Verify Deps and Codegen actions.

(e.g.) https://github.com/knative-sandbox/net-kourier/pull/509/checks?check_run_id=2515042767

Now I am wondering if update-deps bot should create the PR or .github/workflows/knative-verify.yaml should exclude the module name diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant