Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMQ Source docs out of date #763

Closed
gab-satchi opened this issue May 13, 2022 · 1 comment · Fixed by #777
Closed

RMQ Source docs out of date #763

gab-satchi opened this issue May 13, 2022 · 1 comment · Fixed by #777
Assignees
@gabo1208
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
MVP

Comments

@gab-satchi
Copy link
Contributor

The installation and usage docs here is out-of-date. It has no references to connectionSecret which is a required field if RMQ resources aren't predeclared (predeclared: false).

This issue is to add references to connectionSecret as well as verify the rest of the doc.
@gab-satchi gab-satchi added the kind/bug Categorizes issue or PR as related to a bug. label May 13, 2022
@gab-satchi gab-satchi added this to the MVP milestone May 13, 2022
@gabo1208
Copy link
Contributor

/assign

@gabo1208 gabo1208 mentioned this issue May 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabo1208 gabo1208

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

fixed source docs gabo1208/eventing-rabbitmq
2 participants
@gabo1208 @gab-satchi