-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation webhook for Trigger. #338
Comments
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale |
We should also add validation around delivery settings, e.g. retries. cc/ @benmoss |
/assign |
I'm not sure how changing the DLQ would result in dropped events. It seems like we'd stop one dispatcher and create a new one on the same queue. I created #465 since we don't handle changing the DLQ very well right now |
It should disallow some changes because the underlying resources are immutable, and the only way to update them is to delete/recreate. For example, changing a Delivery.DeadLetterSink results possibly in creation/deletion of queues and will create dropped events which is probably unexpected from the users POV.
The text was updated successfully, but these errors were encountered: