Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation webhook for Trigger. #338

Closed
vaikas opened this issue Jun 7, 2021 · 5 comments · Fixed by #468
Closed

Add validation webhook for Trigger. #338

vaikas opened this issue Jun 7, 2021 · 5 comments · Fixed by #468
Assignees
Milestone

Comments

@vaikas
Copy link
Contributor

vaikas commented Jun 7, 2021

It should disallow some changes because the underlying resources are immutable, and the only way to update them is to delete/recreate. For example, changing a Delivery.DeadLetterSink results possibly in creation/deletion of queues and will create dropped events which is probably unexpected from the users POV.

@github-actions
Copy link

github-actions bot commented Sep 6, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2021
@xtreme-sameer-vohra
Copy link
Contributor

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2021
@embano1
Copy link
Contributor

embano1 commented Sep 19, 2021

We should also add validation around delivery settings, e.g. retries.

cc/ @benmoss

@benmoss
Copy link
Contributor

benmoss commented Oct 18, 2021

/assign

@benmoss
Copy link
Contributor

benmoss commented Oct 19, 2021

I'm not sure how changing the DLQ would result in dropped events. It seems like we'd stop one dispatcher and create a new one on the same queue. I created #465 since we don't handle changing the DLQ very well right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants