Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 Internal Server Error when confirming list subscription twice #772

Closed
NicoHood opened this issue Apr 8, 2022 · 3 comments
Closed

500 Internal Server Error when confirming list subscription twice #772

NicoHood opened this issue Apr 8, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@NicoHood
Copy link
Contributor

NicoHood commented Apr 8, 2022

Version:

  • listmonk: 2.1.0

Description of the bug and steps to reproduce:
A client of us triggered a very "nice" edge case bug: When you click the opt-in button twice of a mail, listmonks shows a 500 Server error. This message comes from the webserver, not listmonk itself and it a lot confusing for non-technical people.

It should show rather a message "You've already opted in" or so.

@NicoHood NicoHood added the bug Something isn't working label Apr 8, 2022
@knadh knadh closed this as completed in 12b845e May 3, 2022
@NicoHood
Copy link
Contributor Author

NicoHood commented May 3, 2022

What would the UI now show?

@knadh
Copy link
Owner

knadh commented May 5, 2022

The message remains the same. There are no subscriptions to confirm. The incorrect status code (500) is fixed.

@NicoHood
Copy link
Contributor Author

NicoHood commented May 5, 2022

Wouldn't it make sense to add a message, that the subscribtion was already confirmed? If that differenciation is not possible, maybe something like There are no subscriptions to confirm. Maybe they have already been confirmed? would be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants