Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Updating a subscriber also sends opt-in #656

Closed
marcinkunert opened this issue Jan 10, 2022 · 1 comment
Closed

[API] Updating a subscriber also sends opt-in #656

marcinkunert opened this issue Jan 10, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@marcinkunert
Copy link
Contributor

marcinkunert commented Jan 10, 2022 •
edited
Loading

I've noticed that the API method: PUT /api/subscribers/:id described as Updates a subscriber by ID (https://listmonk.app/docs/apis/subscribers/) also causes an opt-in campaign sendoff.

In my opinion, this method should only change the subscriber data.
@marcinkunert marcinkunert added the bug Something isn't working label Jan 10, 2022
@knadh knadh closed this as completed in 04ea18c Jan 15, 2022
@knadh
Copy link
Owner

knadh commented Jan 15, 2022

Thanks for pointing this out @marcinkunert. Fixed this behaviour and also added an explicit option on the update UI.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knadh @marcinkunert