AWS S3 URL rendered when custom S3-compatible service configured

[benaltair]

Version:

• listmonk: v2.0.0
• OS: Configured through Heroku one-click

Description of the bug and steps to reproduce:

1. Set custom S3-compatible backend URL
2. Set Bucket type to Private
3. Navigate to Media gallery
4. Click on or hover over the ↗ symbol to open the image in a new tab
5. Observe the Amazon URL, incongruent with the custom URL set in settings

Screenshots:

Settings:

Wrong URL in media gallery:

[benaltair]

Setting the bucket type for Public fixes the URL shown in the frontend.

[benaltair]

Note: the missing thumbs are due to a separate issue #496

[knadh]

I'm unable to reproduce the issue where the custom backend URL is ignored and the amazonaws.com URL is rendered on the uploads. In fact, the amazonaws.com URL is not stored in the database alongside the files and neither is it present anywhere in the codebase.

Can you share the API response? (https://yoursite.com:9000/api/media)

[benaltair]

I might be missing something, but I thought this was the culprit:

listmonk/internal/media/providers/s3/s3.go

Line 39 in 823f11e

opt.URL = fmt.Sprintf("https://s3.%s.amazonaws.com", opt.Region)

Unfortunately we're moving in a different direction and I don't have a Listmonk instance running at this time, but I'm keeping it in mind for an upcoming project.

[knadh]

I might be missing something, but I thought this was the culprit:

That can't be it. That bit is a fallback that only applies when the URL is empty.

Unfortunately we're moving in a different direction and I don't have a Listmonk instance running at this time, but I'm keeping it in mind for an upcoming project.

Sure. Closing the issue for now. Please re-open if you face this again. Thanks!