-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add gcd/lcm Semigroup to segment tree #163
feat(core): add gcd/lcm Semigroup to segment tree #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとう。動いてそうだし基本的にはよさそう。しかし 2 点だけ更新をお願いしたい
- min/max とは違って gcd/lcm は型引数 (
std::max<T>(a, b)
とか書くときのT
に相当するやつ) を取らないんだけど、これを消し忘れてるので消しておいてほしい (レビューコメント参照)。付いててもバグなく動きはするけど、後々混乱を生むと思うので - おそらくローカルで動作確認をしてくれたと思います。そのときに使ったスクリプトを
examples/
ディレクトリの中に追加しておいてほしい。詳細な手順は Collect examples #141 にあります
pattern Gcd1' t e = AppBuiltin11 Gcd1 t e | ||
|
||
pattern Lcm1' t e = AppBuiltin11 Lcm1 t e | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pattern Gcd1' t e = AppBuiltin11 Gcd1 t e | |
pattern Lcm1' t e = AppBuiltin11 Lcm1 t e | |
pattern Gcd1' e = AppBuiltin1 Gcd1 e | |
pattern Lcm1' e = AppBuiltin1 Lcm1 e | |
ここの t
は型引数 (std::max<T>(a, b)
とか書くときの T
と同じ) なのだけど、gcd/lcm の場合は int 専用なのでなしでよい
(ここに合わせて他の場所も更新しないとだめかも)
(conflict についてはそのままで構いません。こちらで merge 時に直します。もちろん解消してくれてもよい) |
Co-authored-by: Kimiyuki Onaka <[email protected]>
Co-authored-by: Kimiyuki Onaka <[email protected]>
close #152