Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows & OSX binaries 5 years old #1043

Closed
boelle opened this issue Apr 17, 2020 · 17 comments
Closed

Windows & OSX binaries 5 years old #1043

boelle opened this issue Apr 17, 2020 · 17 comments
Labels

Comments

@boelle
Copy link

boelle commented Apr 17, 2020

the win bin is dated 5 years old, any reason that it has not been updated when the git is updated less than a day ago?

site: https://www.pronterface.com/
direct link: http://kliment.kapsi.fi/printrun/

@kliment
Copy link
Owner

kliment commented Apr 18, 2020

Please use this instead https://github.com/kliment/Printrun/releases

@kliment kliment closed this as completed Apr 18, 2020
@boelle
Copy link
Author

boelle commented Apr 18, 2020

oh i see it
but still 2 years old

@boelle
Copy link
Author

boelle commented Apr 18, 2020

2.0.0 rc5

image

and that is before it opens the main window

@DivingDuck
Copy link
Collaborator

Yea, that's the one that is crashing with windows 10. You need to compile it new.

@boelle
Copy link
Author

boelle commented Apr 18, 2020

i dont know how, just a "dumb" windows user

@boelle
Copy link
Author

boelle commented Apr 18, 2020

well 1.6.0 does the trick so far

@DivingDuck
Copy link
Collaborator

Well, I cant attach it here, it's too big as attachment. So you need to wait for an update from the owner of this project.

@rockstorm101
Copy link
Collaborator

Yea, that's the one that is crashing with windows 10. You need to compile it new.

Hi @DivingDuck, do you happen to know what's changed in Windows that makes current binary useless?

@DivingDuck
Copy link
Collaborator

Not really to be honest. I was running before v1.6 and v2.0RC2 w/o this problem. But RC5 never run on my PC with Windows 10.
Mid last year I setup a new Python virtual environment in VS 2019 from where it build correct and, as I remember, it took me a while to get this running.

@kliment kliment reopened this Apr 18, 2020
@DivingDuck
Copy link
Collaborator

@kliment, if you want, I can send you a compiled version as I did it already for other too.

@DivingDuck
Copy link
Collaborator

DivingDuck commented Apr 19, 2020

@rockstorm101 . Your question let me not sleeping :)
... anyway I had to figure out this for me too as with building a new environment I had the same problem with a crashing windows application's.

Here is the solution I found so fare and works for me:

It turned out that the actual pyinstaller (v3.6) seems to be the root cause of this error. For more information you can follow a discussion about this issue here:
pyinstaller/pyinstaller#2137

To solve the problem uninstall the actual pyinstaller and install instead the developer version for the virtual environment:
pip uninstall pyinstaller
pip install https://github.com/pyinstaller/pyinstaller/archive/develop.zip

There is also some confusion potential for "how to build a windows environment" for running and building a windows application. For most users the given "suggestions" at all the different places in files, wiki and readme's will lead to a point where nothing will work. Maybe a good point to clean up too.

@rockstorm101
Copy link
Collaborator

Thanks a lot for sharing you findings, let's hope that pyinstaller is fixed soon, one cannot rely on development versions for too long.

Please feel free to submit a PR with the correct method for building on Windows. I believe this could save a lot of headaches to future Printrun users.

@MichaelDu9226
Copy link

@DivingDuck Please share the correct method for building on Windows,thank you

@DivingDuck
Copy link
Collaborator

DivingDuck commented Jun 6, 2020

I use VS2019 as programming environment and wrote me a little help instruction how I build my windows version of Pronterface. It took me too a while to find a way getting it running. Not perfect but maybe helpful for you too.
https://github.com/DivingDuck/Printrun/wiki/How-to-setup-Printrun-with-Visual-Studio-2019

@rockstorm101
Copy link
Collaborator

Hi @boelle and @DivingDuck, could you please confirm the latest version 2.0.0rc7 works as expected? If so, would you consider this issue closed?

@DivingDuck
Copy link
Collaborator

Hi @rockstorm101, the compiling issues should be gone since quite some time if you use the modified batch file. I just update my rep

Regarding RC7, there was an error what was solved from @volconst later.
Reference: #1069 (comment) and #1111
It is maybe a good idea to make a new RC

For the main point in this issue here, there is an updated batch file in my repository (branch Gauges) called release_windows.bat that do more or less everything for compiling the windows version local. Maybe we should update the existing with my version.
https://github.com/DivingDuck/Printrun/blob/Gauges/release_windows.bat

I guess, you can close this issue.

@rockstorm101
Copy link
Collaborator

Hi @rockstorm101, the compiling issues should be gone since quite some time if you use the modified batch file. I just update my rep

Regarding RC7, there was an error what was solved from @volconst later.
Reference: #1069 (comment) and #1111
It is maybe a good idea to make a new RC

Thanks, I understand the Windows executable then works fine but it doesn't include the new layer change algorithm. I'll close this issue on that basis then.

For the main point in this issue here, there is an updated batch file in my repository (branch Gauges) called release_windows.bat that do more or less everything for compiling the windows version local. Maybe we should update the existing with my version.
https://github.com/DivingDuck/Printrun/blob/Gauges/release_windows.bat

Good stuff, I would submit your proposal on a PR so it can be discussed in a more appropriate forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants