Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DST (daylight saving time) not switching back? #145

Open
rrednaxela opened this issue Oct 26, 2020 · 5 comments
Open

DST (daylight saving time) not switching back? #145

rrednaxela opened this issue Oct 26, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@rrednaxela
Copy link

After falling back from DST to normal time on Sunday morning the time on my BHT-002-GALW didn't adjust. Today around 20:00 I clicked save on the 'Configure clock' page, and after the reboot the time was ok.
I have configured the defaults, pool.ntp.org and time zone server http://worldtimeapi.org/api/ip
How often does the software update the time?
I have 2 thermostats on 1.18, same behavior on both.

@fashberg
Copy link

Klaus pulled that part of my fork and there was a bug in my Time Zone Implementation (mixed Northern and Southern Hemisphere).

Check fashberg/WThermostatBeca#62 and
fashberg/WThermostatBeca@274a38e

@fashberg
Copy link

Nope. Completely different here and no Northern/Southern Mismatch https://github.com/klausahrenberg/WThermostatBeca/blob/master/WThermostat/src/WClock.h#L515
Then something different.

@rrednaxela You shoud share a screenshot of your TimeZone Settings

@rrednaxela
Copy link
Author

@rrednaxela You shoud share a screenshot of your TimeZone Settings
just the defaults
image

Provided that the time was correct after reboot, it seems the condition in line 129 is not met? Or it never gets there?
I looked a bit at

validTime->setBoolean((lastNtpSync > 0) && ((!this->useTimeZoneServer->getBoolean()) || (lastTimeZoneSync > 0)) && (now - lastTry < (3 * 60 * 60000)));

  • lines 112, 129:
    How much is 60000? 1 minute (according to comment in L104)?

What is then the point of " (now - lastTimeZoneSync > 60000)" in L129? Only update timezone if last timezonesync was more than 1 min ago? If the whole loop anyway runs only every 3 hours?

@klausahrenberg klausahrenberg self-assigned this Jan 23, 2021
@klausahrenberg klausahrenberg added the bug Something isn't working label Jan 23, 2021
@martin072
Copy link

Bit of an old topic, but found out the same, but the other way around. DST settings were not applied after the 27th of March. I changed the NTP server to nl.pool.ntp.org, and after a reboot the time was correct again.

@helmar74
Copy link

Same here today with version 1.36.
Clock didn't change with this settings:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants