Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seems to work #1

Closed
fdalfa opened this issue Sep 7, 2023 · 5 comments
Closed

Doesn't seems to work #1

fdalfa opened this issue Sep 7, 2023 · 5 comments

Comments

@fdalfa
Copy link

fdalfa commented Sep 7, 2023

Ciao,

I tried it on a 3.5.8 netbox and it doesn't seems to work. Here the plugin config
PLUGINS_CONFIG = { "netbox_old_search": { "replace_search": False, # Hijacks the top search bar in netbox, redirecting to this plugins search method instead "show_menu": True # Shows a link to the old search form in the plugin menu } } I see the link in the plugin menu but the search functionality still seem the new one
immagine
where am I wrong?

thanks and regards,
Fabrizio

@kkthxbye-code
Copy link
Owner

When clicking the Old Search link, what URL are you taken to and how does it look?

You sure you are not using the top search bar? That requires setting replace_search to True, which you have set to False currently.

@fdalfa
Copy link
Author

fdalfa commented Sep 7, 2023

Ciao!

When clicking the Old Search link, what URL are you taken to and how does it look?

netbox/plugins/old-search/search/ and it shows the plugin's search
immagine
but the search action bring me to the new global search netbox/search/?q=371; if I try manually the plugin's url netbox/plugins/old-search/search/?q=371 it works like a charm
immagine

I'd like to don't replace the global search and have the option to use the old search in the plugin menu.

thanks and regards,
Fabrizio

@kkthxbye-code
Copy link
Owner

Ahh gotcha, I'll check it out.

@kkthxbye-code
Copy link
Owner

I release v0.1.3 with a fix, could you try that out?

@fdalfa
Copy link
Author

fdalfa commented Sep 7, 2023

ciao!

I tried and it works!

thansk and regards
Fabrizio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants