Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev(SSJ): use OZ contracts #1521

Open
obatirou opened this issue Oct 21, 2024 · 5 comments · May be fixed by #1558
Open

dev(SSJ): use OZ contracts #1521

obatirou opened this issue Oct 21, 2024 · 5 comments · May be fixed by #1558
Assignees
@manlikeHB
Labels
open for contribution

Comments

@obatirou
Copy link
Collaborator

Remove custom implementation (ownable and upgradeable) that were copy from OZ and add the OZ contract dependencies.
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Oct 21, 2024
@manlikeHB
Copy link

Hi @obatirou, can I work on this?

@ClementWalter
Copy link
Member

hey @manlikeHB sure, I assigned you

@ClementWalter ClementWalter moved this from 🆕 Backlog to 🧑‍💻 Open contributor in Kakarot on Starknet Oct 25, 2024
@manlikeHB
Copy link

Hi @ClementWalter, I realized SSJ contains a custom openzeppelin package which contains an ERC20 contract. Adding the the OZ dependency will cause a clash between the two.

Should I proceed to removing the custom openzeppelin package and use OZ's component for the ERC20 contract?

@obatirou
Copy link
Collaborator Author

Hi @ClementWalter, I realized SSJ contains a custom openzeppelin package which contains an ERC20 contract. Adding the the OZ dependency will cause a clash between the two.

Should I proceed to removing the custom openzeppelin package and use OZ's component for the ERC20 contract?

Yes, please do so
This is the goal of this issue: remove the custom OZ packages and use the official ones

@manlikeHB manlikeHB linked a pull request Oct 31, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manlikeHB manlikeHB

Labels
open for contribution
Projects
No open projects
Kakarot on Starknet
Status: 🧑‍💻 Open contributor
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use OZ contracts manlikeHB/kakarot
4 participants
@ClementWalter @obatirou @manlikeHB and others