Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS / Linux compatibility #13

Closed
MortenL opened this issue Sep 16, 2024 · 1 comment
Closed

MacOS / Linux compatibility #13

MortenL opened this issue Sep 16, 2024 · 1 comment

Comments

@MortenL
Copy link

MortenL commented Sep 16, 2024

Currently there is a bug/type-o (case of noCodeDeliveryApi differs from reality) in overview.controller.js line 16 and 23
{ name: 'Querying', icon: 'icon-filter-arrows', view: '/App_Plugins/noCodeDeliveryApi/backoffice/noCodeDeliveryApi/query.html', active: requestMethod === 'overview', alias: 'noCodeDeliveryApiOverview' }, { name: 'Clients', icon: 'icon-sitemap', view: '/App_Plugins/noCodeDeliveryApi/backoffice/noCodeDeliveryApi/clients.html', active: requestMethod === 'client', alias: 'noCodeDeliveryApiClient' }

it should be

{ name: 'Querying', icon: 'icon-filter-arrows', view: '/App_Plugins/NoCodeDeliveryApi/backoffice/noCodeDeliveryApi/query.html', active: requestMethod === 'overview', alias: 'noCodeDeliveryApiOverview' }, { name: 'Clients', icon: 'icon-sitemap', view: '/App_Plugins/NoCodeDeliveryApi/backoffice/noCodeDeliveryApi/clients.html', active: requestMethod === 'client', alias: 'noCodeDeliveryApiClient' }

switching line 17 in DeployServiceBase from

private const string DirectoryName = "NoCode\\DeliveryApi";

to

private readonly string _directoryName = "NoCode" + Path.DirectorySeparatorChar + "DeliveryApi";

further enhances compatibility with non-windows environments.

I tried to make a pull request, but weren't allowed to commit a new branch.

@kjac
Copy link
Owner

kjac commented Jan 1, 2025

Fixed in #12

Released in V1.0.4

@kjac kjac closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants