Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.so file missing in release tar for linux architecture. #845

Closed
MohitMaliFtechiz opened this issue Nov 15, 2022 · 6 comments · Fixed by kiwix/kiwix-build#554
Closed

.so file missing in release tar for linux architecture. #845

MohitMaliFtechiz opened this issue Nov 15, 2022 · 6 comments · Fixed by kiwix/kiwix-build#554
Assignees
Labels
Milestone

Comments

@MohitMaliFtechiz
Copy link

Tar uploaded at https://download.kiwix.org/release/libkiwix/ for linux architecture missing .so file that is required for running test at java-libkiwix.

@kelson42
Copy link
Collaborator

@MohitMaliFtechiz which file exactly?

@kelson42 kelson42 self-assigned this Nov 15, 2022
@kelson42 kelson42 added this to the 12.0.0 milestone Nov 15, 2022
@kelson42
Copy link
Collaborator

I confirm, this is missing!!!

@mgautierfr
Copy link
Member

This is surprising.

But it should be fixed with commit kiwix/kiwix-build@0226d7a on kiwix/kiwix-build#548
(At least I will check that with kiwix/kiwix-build#548)

@kelson42 kelson42 removed their assignment Nov 16, 2022
@mgautierfr
Copy link
Member

Tar uploaded at download.kiwix.org/release/libkiwix for linux architecture missing .so file that is required for running test at java-libkiwix.

Do you really need the linux architecture ? You should better use the android architecture no ?

A proper publication of libkiwix should use a "mixed" build (dependencies build statically and libkiwix build dynamically).
But libkiwix doesn't compile currently in mixed form on linux. The publication of this archive is a bug in the kiwix-build process where it build libkiwix statically. This wrong publication has been introduced when adding the publication of libkiwix for android.
I think we should simply remove it (at least for now)

@kelson42
Copy link
Collaborator

kelson42 commented Nov 16, 2022

Tar uploaded at download.kiwix.org/release/libkiwix for linux architecture missing .so file that is required for running test at java-libkiwix.

Do you really need the linux architecture ? You should better use the android architecture no ?

Here my feedback as I'm the one to push this.

First this is java-libkiwix, not android-libkiwix, so even if this is true that our usage of the moment is on Android, I think it would be a bad approach to not include x86_64 in it.

Then, there is the current question of the unit and automated testing of the java-libkiwix ; if we test one of the Android binding then we will have to run the unit tests. the code coverage, ... in an emulator. This is not something I want because it add an unecessary layer of emulation which is going to slow down and probably even fragilize the whole CI. Therefore, it is preferable to test it natively on x86_64.

@mgautierfr
Copy link
Member

Ok. I will remove thing related to this issue on kiwix/kiwix-build#548 and fix this is another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants