Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move source code for libzim wasm in kiwix-js repository #867

Closed
mossroy opened this issue Jun 3, 2022 · 3 comments
Closed

Move source code for libzim wasm in kiwix-js repository #867

mossroy opened this issue Jun 3, 2022 · 3 comments
Milestone

Comments

@mossroy
Copy link
Contributor

mossroy commented Jun 3, 2022

It's currently in https://github.com/mossroy/libzim_wasm
Now that #513 is solved, we don't need to keep it separated any more, IMHO.

It should be moved in this kiwix-js repo (probably in branch https://github.com/kiwix/kiwix-js/tree/libzim-experiments at the beginning), with the necessary information to build libzim.

@mossroy mossroy added this to the v3.6 milestone Jun 3, 2022
@mossroy
Copy link
Contributor Author

mossroy commented Jun 3, 2022

The most important part is the C "glue" code that allows to call libzim from javascript (currently in file demo_file_api.cpp).
Note that, in the mid-term, compiling the libzim itself should become part of kiwix-build CI: kiwix/kiwix-build#503
So that, in kiwix-js, we would take the already-compiled libzim binary files (in the version we choose), and only compile the glue C code

@kelson42
Copy link
Collaborator

kelson42 commented Nov 13, 2022

Hmm, wonder if this ticket is not deprecated, or if this code in not already in kiwix/kiwix-build because of kiwix/kiwix-build#548... or this is a ticket for openzim/javascript-libzim?

@mossroy
Copy link
Contributor Author

mossroy commented Nov 13, 2022

I'm closing this issue, indeed.
The C glue code is now in openzim/javascript-libzim and kiwix-js should take the libzim binary from it (with the javascript bindings)
What will probably remain is to add clear explanations on how to check the source code and reproduce the build (at least for the Mozilla addons reviewers). Feel free to create a new ticket for that if you think it might be forgotten (see #910 (comment))

@mossroy mossroy closed this as completed Nov 13, 2022
@Jaifroid Jaifroid modified the milestones: v3.9, v3.7 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants