-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.3.0 #802
Comments
@kelson42 - [I fixed tick boxes above] I agree we are quite close. We don't need to do everything marked as v3.3, we can push those not complete and those that are not essential to v3.4. I'll add the current PRs we should merge to this. |
I fixed the version numbers in the tick boxes. I agree we're close to have enough changes to release a 3.3 |
See #805 for initial changelog. |
I suggest that we try to do this release this week-end, if possible. |
I've done some tests on my Firefox OS device, with various ZIM files. |
@mossroy I've just updated the implementation at moz-extension.kiwix.org to be inline with current master. This will facilitate testing. I'd like to do a bit more testing of the switch between JQuery and SW in Firefox extension, as this is the headline feature of this release... I propose to complete these tests today, so we can create the tag tomorrow. What should we do about the Ubuntu phone release? Cross fingers and hope? I'm not even sure ernesst is using that version any more! |
Thanks. Regarding Ubuntu phones, I think we can not do anything more than "cross fingers", until we have another tester.
|
Hello, just passing by :) Now that I'm here, I cannot seem to find any click. Do you have a link or do I have to build the project? |
@cibersheep Thank you, amazing you saw this! There's a click here: http://download.kiwix.org/nightly/2022-02-05/ . The only thing is that there was a merge this morning, so it might be good to test also after tonight's is generated. If you're able to test, that would be great. |
Ah! Awesome. Thanks. I can do that ;) Edit: I can also do this: https://forums.ubports.com/topic/7390/kiwik-ja-needs-testers ^__^ |
I'm testing on Pixel 3a latest dev:
|
@cibersheep Thank you. So you get the spinner but it never stops, and doesn't show an actual article? |
So according to the log, the required decoder (ZSTD) is not loading, as we get I haven't seen a need for EDIT: I'm not sure why the ContentPickerDialog is throwing an error, but as it seems you were able to pick the ZIM archive and even search it, then I assume that error is immaterial. The more serious error is not loading the decoder. We have two decoders, XZ for older ZIM archives, and ZSTD for newer ones (last 18 months or so). We only instantiate the one needed for a specific ZIM archive. There is an XZ-encoded split ZIM in the Searching for results does not require the decoder, but accessing an article does. |
@cibersheep : great to have you here to test on Ubuntu Touch! When we have more information, we should open a separate ticket for that. |
This was a lot faster! Nice.
I think TypeError is an error for the toolkit. Nothing specific for Kiwix app
Is a known error. It shouldn't prevent the Picker to load the file. As I'm able to search for articles, I assume they are loaded correctly (?)
When opening the app for second time:
Mmm v3.2.0 seems not to load the zim file at all. Decoder error is the same. I'll test older versions in a sec Version 3.1.0 works properly (loads zim file, search and article shows). Decoder error is not present (aka it loads) |
@cibersheep Yes, the fact you can pick the ZIM and search for articles (and get a list of articles matching the search) shows that the file picker error is immaterial. The issue is the way the decoder is failing to load. It's strange, because the decoder loads in IE11 when accessing from the file:// protocol, so it can't be an issue with the fact that the Ubuntu touch framework uses file:// The warning dialogue box above: this should actually disappear with tonight's nightly, because this morning's merge was precisely a fix for a bug that makes incompatible frameworks attempt to switch to Service Worker mode. The message shown is actually harmless, it's just telling you that the app tried (erroneously) to switch to using a Service Worker when that is not possible over the file:// protocol. The fact that the test implementation works in the device's browser shows that there is no fundamental incompatibility in the code, which is good. It also means that it should be possible to use this app as an offline-first PWA if all else fails (and if Service Worker mode is supported when accessing the https:// implementation). However, the main task is to find out why 3.1.0 works, when the later ones don't. |
OK, it's undoubtedly this change in v3.2.0:
I think loading WASM is failing, and the fallback option is not being detected. I don't know exactly why. It works in Chromium extensions which also use the file:// protocol and a Chromium browser, so there is no obvious reason why it's failing here. As a quick fix (monkey wrench.......) we could explicitly load the ASM versions (which are actually just as fast, btw) if we can detect that this will fail. I think we do something like that for IE11. But this should probably be a new issue. I'll see if I can move these comments. |
Yes, but it's probably not a big issue. Don't bother. |
@kelson42 : can you upload https://download.kiwix.org/nightly/2022-02-06/kiwix-chrome-unsigned-extension-3.3.0.zip on Chrome store? |
@mossroy Submitted to review, should be published until tomorrow. |
OK, it looks like the failure to update the extension PWA wasn't a problem with my workflow scripting, but a failure on the docker side. Here is the workflow: https://github.com/kiwix/kiwix-js/runs/5084057842?check_suite_focus=true I'd forgotten that I had in fact written code to modify the version number in the source files, and the new number is indeed set by the tag. We do know that the scripting works here, so long as VERSION was in fact set to TAG_VERSION (because we use the same scripting to set the version from the UI). Let me know if you think I need to change anything. |
I'm wondering if it could not come from the fact that our tags are named "3.3.0", and not "v3.3.0" (which is more common). |
Well here is where we set the tag-pattern that the job is supposed to use: https://github.com/kiwix/kiwix-js/blob/master/.github/workflows/publish-extension.yaml#L67 And remember that the job runs correctly when we set a tag from the Action Dispatch UI, without a What I would like to do is to add some echo statements so that if it fails again we get a better log of what values we are passing. We can also test the logging before 3.3.1 because if we push master again as 3.3, there will be no change for users. I'll make a PR for logging (in the Workflow). |
But it is possible that there is a coding issue upstream in the GitHub action, which somehow ignores the |
@mossroy Will 3.3.1 need a changelog with the two Ubuntu Touch updates? |
We should indeed add this version 3.3.1 to the changelog file |
I've done some basic tests on Firefox and Chromium (including as extensions), and on Firefox OS. Found no regression (risk is very low based on what has changed from 3.3.0) In my opinion, we should deploy this version 3.3.1 for all platforms. The race condition might have affected some other devices we did not hear about. |
OK, fine by me! I tested on IE11 in case that's useful, and saw no regression. On IE11 it now shows the decompressors as uninitialized in the API panel, until a ZIM is loaded, at which point it populates the panel. This is simply to do with the fallback to ASM, as the WASMs get initialized (loaded) by the script, whereas ASM is just plain JS (albeit optimized). Everything works well on IE11. |
OK that's fine. |
Cool for the PWA! Nice job |
I've unchecked what needs to be done again for 3.3.1 in the checklist of this ticket |
3.3.1 uploaded to Edge store. |
3.3.1 uploaded to Chrome store. |
Download.kiwix.org updated with the 3 versions |
I'm afraid not: I send you a couple of logs (they might be a bit useless): Update from test app to 3.3.1 and tried to open local zim Cleared cache: Cleared cache, uninstall, reboot phone, reinstall Reset app from in app |
@cibersheep The failure to load WASM is expected: it is supposed to fall back gracefully to ASM, and that is what was happening with the nightly, right? However, it shouldn't then error out and fail to load/display a ZIM (if I've understood correctly what is happening). Could you kindly check the last nightly that works? From http://download.kiwix.org/nightly/ . I don't see what can have changed between the last nightly that was working and release... But hopefully we can get to the bottom of it. |
The apparmor polices are how the app works on the phone itself. That have been caught but the test app as well. I'm prety sure you can ignore them |
I've created #839 to work on this. Let's continue discussion there. |
We can probably close this thread. @kelson42 will you be able to do some publicity for v3.3.1? |
The 3.3 milestone is already quite interesting and has still a lot of work to do. I see work to do for at least 4 months. Last release is already almost 6 months ago. Release early, release often is good. I want to encourage you to reassess the milestone to 3.3.0.
Possibly merge Added bootstrap modal for alert and confirm popups:WIP #798 #804The text was updated successfully, but these errors were encountered: