Showing a warning dialog when copying/moving the ZIM chunks in PS version. #4170
+47
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4170 +/- ##
============================================
- Coverage 56.93% 56.86% -0.08%
Complexity 1518 1518
============================================
Files 313 313
Lines 13402 13417 +15
Branches 1666 1666
============================================
- Hits 7631 7630 -1
- Misses 4614 4633 +19
+ Partials 1157 1154 -3 ☔ View full report in Codecov by Sentry. |
* Now all the ZIM chunks are copying/moving correctly. * Improved the warning message to inform user what should they do after copying/moving all the ZIM chunks. * Implement a feature to directly view the copied/moved ZIM chunks by clicking on the button in warning dialog.
…/moving the ZIm chunks.
…ns are clear to the user.
…rify the ZIM chunks are copied/moved properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4045
screen-20250109-185127.mp4