Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidBrowser.open() should return a value #855

Closed
WillDHB opened this issue Jul 29, 2016 · 1 comment
Closed

AndroidBrowser.open() should return a value #855

WillDHB opened this issue Jul 29, 2016 · 1 comment

Comments

@WillDHB
Copy link

WillDHB commented Jul 29, 2016

The webbrowser.open() method and its variants expect the open methods of browsers to return a True value if the operation is successful, and a False value otherwise.

Presently, the AndroidBrowser does not return a value for these methods, causing webbrowser.open() to return False, indicating failure.

@inclement
Copy link
Member

I've made these functions return True (61b95b6). Right now there's no way to return False, but I'm not sure what even happens if this fails (all we know is that we asked the system to opena browser), so I guess it's okay for now.

If anyone has a better idea, such a contribution would be welcome.

Thanks for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants