Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: webview, pygame and service_only bootstraps are hardwired to Python 2.7 #1497

Closed
ghost opened this issue Nov 30, 2018 · 6 comments

Comments

@ghost
Copy link

ghost commented Nov 30, 2018

The Android.mk Makefiles of all bootstraps other than sdl2 are hardwired to link/include Python 2.7 files. We should fix that at some point (or remove the bootstraps no longer used/properly supported by anyone anyway)

@ghost
Copy link
Author

ghost commented Nov 30, 2018

Also an additional note: the pygame bootstrap also seems to hardcode api level 14 and some other horrible things, it looks like it's in quite a bad shape. Are people still using this, does it even work in its current state with Python 2.7, and what's the plan for the future for the pygame bootstrap?

@inclement
Copy link
Member

inclement commented Dec 3, 2018

My plan for pygame is to just ignore it and eventually remove it if it becomes clearly broken. We seem to have succeeded quite well at getting people to not use it, so maybe we're already at that point. Please feel free to ignore it, or indeed propose removing it, rather than wasting effort on it.
The webview bootstrap would be nice to maintain, and service_only is the same although I'm not sure if anyone really uses it, it was originally introduced and maintained by just one person. I haven't checked your other issues about this yet, but thanks for looking at it and it's certainly correct that it would be ideal to support them properly.

@ghost
Copy link
Author

ghost commented Dec 3, 2018

I personally don't care much for pygame, but that's easy for me to say since I don't use it. Maybe it would be a good idea to get some statistics or ask some users? (is there a good way of doing that?)

As for the others, I agree they might be useful. Maybe a good idea would be to have testapps to be built for them, which might help with at least doing a conscious test if stuff is broken in the future (beyond just relying on travis). Are there any around that can be actually run afterwards?

@inclement
Copy link
Member

About pygame, it's actually easier than having to check if people use it because it's basically a Kivy-only legacy bootstrap. I think it might be able to run pygame apps, but they probably don't work well, e.g. I don't know if they can actually receive touches (Kivy uses a special mouse provider on that bootstrap). Since it's deprecated for Kivy's use, that's the only important thing when deciding to remove it or not. As you say, it has weird hardcoded values that probably make it not usable on the Play store any more anyway.

@ghost
Copy link
Author

ghost commented Dec 3, 2018

Oh yeah I highly doubt you can build it on a >20 api level, which should make it unusable for play store for sure

@ghost
Copy link
Author

ghost commented Jan 30, 2019

I'm closing this since I'm 99% sure @opacam fixed this (let me know if this is wrong and I'll reopen)

@ghost ghost closed this as completed Jan 30, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant