Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidManifest.xml.tmpl should set screenLayout & smallScreenSize #1422

Closed
ghost opened this issue Oct 21, 2018 · 2 comments
Closed

AndroidManifest.xml.tmpl should set screenLayout & smallScreenSize #1422

ghost opened this issue Oct 21, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 21, 2018

Versions

  • Python: all versions should be affected
  • OS: all Android versions with split screen affected
  • Kivy: all versions should be affected
  • Cython: not relevant

Description

AndroidManifest.xml.tmpl should set configChanges to include "screenLayout" when minimum API level >= 4, and "smallScreenSize" (when minimum API level >= 13. Right now only screenSize is set, and as a result, all kivy & p4a apps appear to crash when attempting to use them in side by side / split screen mode (because the SDLActivity is shut down). Of course, some kivy apps might still break in the split screen mode simply by not having a suitable layout, but at least they won't instant crash/terminate in all cases.

Note: it seems either the p4a wrapper or the SDLActivity have some bug so the app won't properly resize the SDL window in split screen mode. However, again, as written above - this is still preferable to the app just shutting down/crashing, so I still think this should be changed even if this isn't fully investigated yet.

buildozer.spec

not applicable

Logs

not applicable

@ghost
Copy link
Author

ghost commented Dec 12, 2018

Will be resolved by #1522

@ghost
Copy link
Author

ghost commented Dec 16, 2018

Fixed

@ghost ghost closed this as completed Dec 16, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants