Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyjnius really should be version pinned. #1415

Closed
ghost opened this issue Oct 20, 2018 · 2 comments
Closed

pyjnius really should be version pinned. #1415

ghost opened this issue Oct 20, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Oct 20, 2018

Versions

latest git master of p4a, no matter what python/cython/kivy used

Description

pyjnius isn't version pinned:

https://github.com/kivy/python-for-android/blob/master/pythonforandroid/recipes/pyjnius/__init__.py#L10

This means even if I stay at a fixed commit of p4a master, I don't get reproducible builds and if someone breaks stuff in pyjnius like right now -> #1414 I might be stuck not being able to do a simple deployment of my application unless I happened to keep a previous full system image with a working combination of things.

This is bad for such a core component. If I stick on a p4a master at least all the core things should be guaranteed to work, because manually meddling around in recipes just to get back to an older version of e.g. pyjnius in an automated build chain is pretty annoying to do.

Even if nobody ever tests the pin and the pin is updated to a broken version, this is a lot better than no pin. (because in that case, everyone can just go back with their main p4a master clone, which is easy, instead of patching inside the recipes folder during the build to avoid broken pyjnius, which is hard and annoying.)

buildozer.spec

not relevant

Logs

not relevant

@ghost ghost mentioned this issue Oct 20, 2018
@ghost
Copy link
Author

ghost commented Nov 23, 2018

Closing since it appears to be pinned now!

@ghost ghost closed this as completed Nov 23, 2018
@KeyWeeUsr
Copy link
Contributor

Ref #1426.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant