Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs say ANDROIDAPI=19 sets minimum API level, but it sets target API level #1352

Closed
ghost opened this issue Sep 4, 2018 · 3 comments
Closed

Comments

@ghost
Copy link

ghost commented Sep 4, 2018

I am pretty certain export ANDROIDAPI=19 doesn't set the API level 19 as the docs claim, because the AndroidManifest.xml has this entry: <uses-sdk android:minSdkVersion="12" android:targetSdkVersion="19" />. (and I have trouble with jarsigner indicating it's at least minimum API level 17 or lower) This suggests it actually sets the target level which is something quite different to the minimum API level.

The docs however suggest ANDROIDAPI sets the minimum level here: https://github.com/kivy/python-for-android/blob/master/doc/source/quickstart.rst with quote: export ANDROIDAPI="19" # Minimum API version your application require(sic)

I suggest this should be fixed!

Edit: improved ticket text with it now being obvious what the issue is

@ghost
Copy link
Author

ghost commented Sep 4, 2018

Edit: was confused how to set minimum api level, but was told in chat it's --minsdk by the always helpful @inclement - thanks!

@ghost ghost changed the title ANDROIDAPI=19 doesn't set minimum API level 19 as the docs claim Docs say ANDROIDAPI=19 sets minimum API level, but it sets target API level Sep 5, 2018
@inclement
Copy link
Member

inclement commented Sep 15, 2018

A lot of this lack of clarity is a symptom of my own confusion back when I got SDL2 working. I've been working to understand this a bit better while looking at python3, and I'll try to make an effort to clear it up when fixing up my work for merging.

Edit: This SO question illustrates how annoying it is to work out what's going on - half the answers contradict one another!

@ghost
Copy link
Author

ghost commented Oct 22, 2018

Fixed now with the merge request being in!

@ghost ghost closed this as completed Oct 22, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant