Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow build process since sh 1.12.5 #1038

Closed
bobatsar opened this issue Apr 13, 2017 · 5 comments
Closed

Slow build process since sh 1.12.5 #1038

bobatsar opened this issue Apr 13, 2017 · 5 comments

Comments

@bobatsar
Copy link
Contributor

Just for you to know, the performance problem when building a dist and recipies are due to a regression in the python module sh since version 1.12.5

I already wrote a bug report and they are working on it, see amoffat/sh#378

@inclement
Copy link
Member

Thanks for the report, I've heard about this but didn't actually know what caused it. If it takes any time for the sh devs to fix it, we can try to work around it in p4a by avoiding the sh module where there are many similar commands.

@bobatsar
Copy link
Contributor Author

In fact just deactivating the following kwargs removes the problem but of course the live output is not workingwhile a command is running, as sh blocks until the command finishes. But this is already a good workaroud, but I would wait a little bit if it gets fixed soon.

kwargs["_iter"] = True
kwargs["_out_bufsize"] = 1
kwargs["_err_to_out"] = True
kwargs["_bg"] = True

@tito
Copy link
Member

tito commented Apr 16, 2017

In the meantime: pip install sh\<1.12.5
Maybe we could reference it manually in the setup.py

@bobatsar
Copy link
Contributor Author

bobatsar commented Jun 7, 2017

It seems they fixed it in sh 1.12.14 (see amoffat/sh#378). I didn't have time to test it.

If anyone can test it this issue can be closed.

@inclement
Copy link
Member

This was worked around on master, no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants