Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove detection logic for docker environment #217

Open
zachmullen opened this issue Aug 12, 2024 · 0 comments
Open

Remove detection logic for docker environment #217

zachmullen opened this issue Aug 12, 2024 · 0 comments

Comments

@zachmullen
Copy link
Contributor

zachmullen commented Aug 12, 2024

In order to get DJDT to work in our docker-compose configuration, we had to add some conditional logic specific to the docker environment, leading to the creation of the _is_docker function.

In lieu of this function, we could read an environment variable that declares that the application is running in docker. For backward compatibility, we could fall back to the existing _is_docker implementation if it's not set.

If we decide to make this change, we should add the proposed environment variable to the docker compose and native environment files in the Resonant cookiecutter.

@brianhelba brianhelba transferred this issue from kitware-resonant/django-composed-configuration Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant