Wrong Color Status Update if Task is taken by Task View (since version 3.5)

[m-kotzyba]

Tasks taken by the "standard" task view do not trigger any change from "open" to "in work" in the process status bar. However, if the task was taken/changed via the task list (only possible for project managers or admins), the error does not appear. Having a look in the task list, the correct Status/color is always correct.

We noticed this error since Kitodo version 3.5.0

[thomaslow]

Hi Michael, I had a look at your problem, because it is related to #5360.

In order to be able to sort processes in the process list by their status bar, it was necessary to store that information in the ElasticSearch index. If the status bar is not showing the correct status of a process, it means that a process was not re-indexed after a change to its status.

Unfortunately, the implementation of the up/down buttons is currently not consistent in that regard:

• When a task status is changed via the "up" button, the task and process is saved, but not always re-indexed.
• When a task status is changed via the "down" button, the task and process is actually not saved at all. Refreshing the page without clicking on "save" will revert the status.

I noticed, after changing a task status the process "save" button is activated (turns blue). Clicking on "save" will then save and re-index the process and show the correct task status. So, I'm not sure what the intended or incorrect behavior in this case is:

1. Either, the idea is to only save changes to the task status with the "save" button, meaning it is not correct that the task status is currently saved immediately when clicking the "up" button (without clicking again on "save").
2. Or, it is correct that any changes to the task status should be saved immediately, meaning we should fix that the process is not re-indexed in the scenario you described above. In this case, the "save" button probably shouldn't turn blue when changing the task status.

From a user experience point of view, I think it would be more consistent that a user needs to confirm any changes with the "save" button. What do you think?

[solth]

@thomaslow thanks a lot for your analysis. This has been a long standing issue with Kitodo 3 because editing one object (a task) within the formular of another object (a process) and saving the "inner" object without clicking the "Save" button of the outer object (or any "Save" button for that matter) always felt very counter-intuitive and contradictory to the other parts of the system - as you mentioned.

I would therefore clearly opt for your first approch, meaning an updated tasks status is only saved when clicking the "Save" button on process edit page. It might initially cause minor confusion because some users are probably already used to the current, faulty behavior, but that does not mean it should not be fixed, in my opinion.