Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated creation of dynamic property on PHP 8.2 #7

Closed
dregad opened this issue Apr 6, 2023 · 2 comments
Closed

Deprecated creation of dynamic property on PHP 8.2 #7

dregad opened this issue Apr 6, 2023 · 2 comments

Comments

@dregad
Copy link

dregad commented Apr 6, 2023

Seen in DokuWiki's PHPUnit logs:

PHP Deprecated: Creation of dynamic property IXR\Message\Message::$currentTag is deprecated in /home/runner/work/dokuwiki/dokuwiki/vendor/kissifrot/php-ixr/src/Message/Message.php on line 105

$this->currentTag = $tag;

There is an existing _currentTag property, so maybe it's just a typo (missing _) ?

private $_currentTag;

@kissifrot
Copy link
Owner

kissifrot commented Apr 14, 2023

Thanks for the report, I will look into it

@dregad
Copy link
Author

dregad commented Apr 15, 2023

Thanks for the fix. Don't know if it's intentional, but it's not mentioned on the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants